set RUSTFLAGS in env

geoarrow · Dec 6, 2024 · e931335 · e931335
1 parent b052913
commit e931335
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 13 deletions.
diff --git a/.github/workflows/python-core-wheels.yml b/.github/workflows/python-core-wheels.yml
@@ -45,10 +45,12 @@ jobs:
           python-version: 3.x
       - name: Build wheels
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           rust-toolchain: nightly
           target: ${{ matrix.platform.target }}
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
+          args: --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
           sccache: "true"
           manylinux: auto
       - name: Upload wheels
@@ -81,9 +83,11 @@ jobs:
   #         python-version: 3.x
   #     - name: Build wheels
   #       uses: PyO3/maturin-action@v1
+  # env:
+  #   RUSTFLAGS: "-Zinline-mir=no"
   #       with:
   #         target: ${{ matrix.platform.target }}
-  #         args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
+  #         args: --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
   #         sccache: "true"
   #         manylinux: musllinux_1_2
   #     - name: Upload wheels
@@ -112,10 +116,12 @@ jobs:
           architecture: ${{ matrix.platform.target }}
       - name: Build wheels
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           rust-toolchain: nightly
           target: ${{ matrix.platform.target }}
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
+          args: --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
           sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4
@@ -143,10 +149,12 @@ jobs:
           python-version: 3.x
       - name: Build wheels
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           rust-toolchain: nightly
           target: ${{ matrix.platform.target }}
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
+          args: --release --out dist --find-interpreter --manifest-path python/${{ matrix.module }}/Cargo.toml
           sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4
@@ -180,15 +188,15 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-      - run: |
-          echo RUSTFLAGS="-Zinline-mir=no" >> $GITHUB_ENV
       - run: pip install pyodide-build
       - name: Build wheels
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           rust-toolchain: nightly
           target: ${{ matrix.platform.target }}
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter --no-default-features --manifest-path python/${{ matrix.module }}/Cargo.toml
+          args: --release --out dist --find-interpreter --no-default-features --manifest-path python/${{ matrix.module }}/Cargo.toml
           sccache: "true"
       - name: Upload wheels
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/python-io-wheels.yml b/.github/workflows/python-io-wheels.yml
@@ -25,11 +25,13 @@ jobs:
 
       - name: Build wheels
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           rust-toolchain: nightly
           target: ${{ matrix.target }}
           manylinux: manylinux_2_28
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
+          args: --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
           before-script-linux: |
             yum update -y
             yum install openssl openssl-devel perl-IPC-Cmd -y
@@ -59,11 +61,13 @@ jobs:
 
   #     - name: Build wheels
   #       uses: PyO3/maturin-action@v1
+  # env:
+  #   RUSTFLAGS: "-Zinline-mir=no"
   #       with:
   #         rust-toolchain: nightly
   #         target: ${{ matrix.target }}
   #         manylinux: auto
-  #         args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
+  #         args: --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
 
   #     # This is currently failing with
   #     # python: command not found
@@ -112,9 +116,11 @@ jobs:
 
       - name: Build wheels - ${{ matrix.platform.target }}
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           target: ${{ matrix.platform.target }}
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
+          args: --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
           sccache: "true"
 
       - name: Install built wheel - ${{ matrix.platform.target }}
@@ -145,10 +151,12 @@ jobs:
 
       - name: Build wheels
         uses: PyO3/maturin-action@v1
+        env:
+          RUSTFLAGS: "-Zinline-mir=no"
         with:
           rust-toolchain: nightly
           target: ${{ matrix.target }}
-          args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
+          args: --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
 
       - name: Install built wheel
         run: |
@@ -184,7 +192,8 @@ jobs:
   #         rust-toolchain: nightly
   #         target: ${{ matrix.target }}
   #         manylinux: musllinux_1_2
-  #         args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
+  # TODO: update rustflags env
+  #         args: --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
 
   #     - name: Install built wheel
   #       if: matrix.target == 'x86_64-unknown-linux-musl'
@@ -227,7 +236,8 @@ jobs:
   #         rust-toolchain: nightly
   #         target: ${{ matrix.platform.target }}
   #         manylinux: musllinux_1_2
-  #         args: RUSTFLAGS="-Zinline-mir=no" --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
+  # TODO: update rustflags env
+  #         args: --release --out dist --find-interpreter -m python/geoarrow-io/Cargo.toml
 
   #     - uses: uraimo/[email protected]
   #       name: Install built wheel