cleanup

rust/geoarrow/src/algorithm/geo/euclidean_distance.rs

@@ -186,7 +186,7 @@ iter_geo_impl!(MultiPolygonArray, PointArray);
 // └─────────────────────────────────┘
 
 // Note: this implementation is outside the macro because it is not generic over O
-impl<'a> EuclideanDistance<Point> for PointArray {
+impl EuclideanDistance<Point> for PointArray {
     /// Minimum distance between two Points
     fn euclidean_distance(&self, other: &Point) -> Float64Array {
         let mut output_array = Float64Builder::with_capacity(self.len());

rust/geoarrow/src/algorithm/geo/within.rs

@@ -142,7 +142,7 @@ iter_geo_impl!(MultiPolygonArray, MultiPolygonArray);
 // └──────────────────────────────────────────┘
 
 // Note: this implementation is outside the macro because it is not generic over O
-impl<'a> Within<Point> for PointArray {
+impl Within<Point> for PointArray {
     fn is_within(&self, rhs: &Point) -> BooleanArray {
         let mut output_array = BooleanBuilder::with_capacity(self.len());
 

rust/geoarrow/src/scalar/coord/interleaved.rs

@@ -97,7 +97,7 @@ impl CoordTrait for InterleavedCoord {
     }
 
     fn x(&self) -> Self::T {
-        *self.coords.get(0).unwrap()
+        *self.coords.first().unwrap()
     }
 
     fn y(&self) -> Self::T {
@@ -118,7 +118,7 @@ impl CoordTrait for &InterleavedCoord {
     }
 
     fn x(&self) -> Self::T {
-        *self.coords.get(0).unwrap()
+        *self.coords.first().unwrap()
     }
 
     fn y(&self) -> Self::T {

rust/geoarrow/src/scalar/geometrycollection.rs

@@ -70,7 +70,7 @@ impl GeometryCollectionTrait for GeometryCollection {
     }
 }
 
-impl<'a> GeometryCollectionTrait for &'a GeometryCollection {
+impl GeometryCollectionTrait for &GeometryCollection {
     type T = f64;
     type GeometryType<'b>
         = Geometry

rust/geoarrow/src/scalar/linestring.rs

@@ -51,7 +51,7 @@ impl NativeScalar for LineString {
     }
 }
 
-impl<'a> LineStringTrait for LineString {
+impl LineStringTrait for LineString {
     type T = f64;
     type CoordType<'b>
         = Coord
@@ -72,7 +72,7 @@ impl<'a> LineStringTrait for LineString {
     }
 }
 
-impl<'a> LineStringTrait for &'a LineString {
+impl LineStringTrait for &LineString {
     type T = f64;
     type CoordType<'b>
         = Coord

rust/geoarrow/src/scalar/multilinestring.rs

@@ -49,7 +49,7 @@ impl NativeScalar for MultiLineString {
     }
 }
 
-impl<'a> MultiLineStringTrait for MultiLineString {
+impl MultiLineStringTrait for MultiLineString {
     type T = f64;
     type LineStringType<'b>
         = LineString
@@ -76,7 +76,7 @@ impl<'a> MultiLineStringTrait for MultiLineString {
     }
 }
 
-impl<'a> MultiLineStringTrait for &'a MultiLineString {
+impl MultiLineStringTrait for &MultiLineString {
     type T = f64;
     type LineStringType<'b>
         = LineString

rust/geoarrow/src/scalar/multipoint.rs

@@ -49,7 +49,7 @@ impl NativeScalar for MultiPoint {
     }
 }
 
-impl<'a> MultiPointTrait for MultiPoint {
+impl MultiPointTrait for MultiPoint {
     type T = f64;
     type PointType<'b>
         = Point
@@ -71,7 +71,7 @@ impl<'a> MultiPointTrait for MultiPoint {
     }
 }
 
-impl<'a> MultiPointTrait for &'a MultiPoint {
+impl MultiPointTrait for &MultiPoint {
     type T = f64;
     type PointType<'b>
         = Point

rust/geoarrow/src/scalar/multipolygon.rs

@@ -49,7 +49,7 @@ impl NativeScalar for MultiPolygon {
     }
 }
 
-impl<'a> MultiPolygonTrait for MultiPolygon {
+impl MultiPolygonTrait for MultiPolygon {
     type T = f64;
     type PolygonType<'b>
         = Polygon
@@ -77,7 +77,7 @@ impl<'a> MultiPolygonTrait for MultiPolygon {
     }
 }
 
-impl<'a> MultiPolygonTrait for &'a MultiPolygon {
+impl MultiPolygonTrait for &MultiPolygon {
     type T = f64;
     type PolygonType<'b>
         = Polygon

rust/geoarrow/src/scalar/point.rs

@@ -2,7 +2,7 @@ use crate::algorithm::native::bounding_rect::bounding_rect_point;
 use crate::algorithm::native::eq::point_eq;
 use crate::array::PointArray;
 use crate::scalar::Coord;
-use crate::trait_::{ArrayAccessor, NativeScalar};
+use crate::trait_::NativeScalar;
 use crate::{ArrayBase, NativeArray};
 use geo_traits::to_geo::ToGeoPoint;
 use geo_traits::PointTrait;
@@ -55,7 +55,7 @@ impl PointTrait for Point {
     }
 
     fn coord(&self) -> Option<Self::CoordType<'_>> {
-        let coord = self.0.value(0);
+        let coord = self.0.coords.value(0);
         if coord.is_nan() {
             None
         } else {
@@ -64,7 +64,7 @@ impl PointTrait for Point {
     }
 }
 
-impl<'a> PointTrait for &Point {
+impl PointTrait for &Point {
     type T = f64;
     type CoordType<'b>
         = Coord
@@ -76,7 +76,7 @@ impl<'a> PointTrait for &Point {
     }
 
     fn coord(&self) -> Option<Self::CoordType<'_>> {
-        let coord = self.0.value(0);
+        let coord = self.0.coords.value(0);
         if coord.is_nan() {
             None
         } else {

rust/geoarrow/src/scalar/polygon.rs

@@ -65,7 +65,7 @@ impl NativeScalar for Polygon {
     }
 }
 
-impl<'a> PolygonTrait for Polygon {
+impl PolygonTrait for Polygon {
     type T = f64;
     type RingType<'b>
         = LineString
@@ -107,7 +107,7 @@ impl<'a> PolygonTrait for Polygon {
     }
 }
 
-impl<'a> PolygonTrait for &'a Polygon {
+impl PolygonTrait for &Polygon {
     type T = f64;
     type RingType<'b>
         = LineString

rust/geoarrow/src/scalar/rect.rs

@@ -44,7 +44,7 @@ impl NativeScalar for Rect {
 }
 
 // TODO: support 3d rects
-impl<'a> RectTrait for Rect {
+impl RectTrait for Rect {
     type T = f64;
     type CoordType<'b>
         = SeparatedCoord