Remove EWKB-specific function (#886)

python/docs/api/core/functions.md

@@ -8,7 +8,6 @@ Interoperability with other Python geospatial libraries (Shapely, GeoPandas) and
         - "!^_"
       members:
         - read_pyogrio
-        - from_ewkb
         - from_geopandas
         - from_shapely
         - from_wkb

python/geoarrow-core/python/geoarrow/rust/core/_rust.pyi

@@ -445,17 +445,6 @@ def read_pyogrio(
         Table
     """
 
-def from_ewkb(input: ArrowArrayExportable) -> NativeArray:
-    """
-    Parse an Arrow BinaryArray from EWKB to its GeoArrow-native counterpart.
-
-    Args:
-        input: An Arrow array of Binary type holding EWKB-formatted geometries.
-
-    Returns:
-        A GeoArrow-native geometry array
-    """
-
 def from_geopandas(input: gpd.GeoDataFrame) -> Table:
     """
     Create a GeoArrow Table from a [GeoPandas GeoDataFrame][geopandas.GeoDataFrame].
@@ -519,7 +508,8 @@ def from_wkb(
     """
     Parse an Arrow BinaryArray from WKB to its GeoArrow-native counterpart.
 
-    This expects ISO-formatted WKB geometries.
+    This will handle both ISO and EWKB flavors of WKB. Any embedded SRID in
+    EWKB-flavored WKB will be ignored.
 
     Args:
         input: An Arrow array of Binary type holding WKB-formatted geometries.

python/geoarrow-core/src/interop/mod.rs

@@ -1,4 +1,3 @@
-pub mod ewkb;
 pub mod geopandas;
 pub mod numpy;
 pub mod pyogrio;

python/geoarrow-core/src/lib.rs

@@ -72,7 +72,6 @@ fn _rust(py: Python, m: &Bound<PyModule>) -> PyResult<()> {
         m
     )?)?;
 
-    m.add_function(wrap_pyfunction!(crate::interop::ewkb::from_ewkb, m)?)?;
     m.add_function(wrap_pyfunction!(
         crate::interop::shapely::from_shapely::from_shapely,
         m

python/tests/interop/test_wkb.py

@@ -28,3 +28,13 @@ def test_geometry_collection():
     assert retour_shapely.geoms[0].geoms[0] == point
     assert retour_shapely.geoms[1].geoms[0] == point2
     assert retour_shapely.geoms[2].geoms[0] == line_string
+
+
+def test_ewkb_srid():
+    geoms = shapely.points([0, 1, 2, 3], [4, 5, 6, 7])
+    geoms = shapely.set_srid(geoms, 4326)
+    assert shapely.get_srid(geoms)[0] == 4326
+
+    ewkb_array = pa.array(shapely.to_wkb(geoms, flavor="extended", include_srid=True))
+    retour = to_shapely(from_wkb(ewkb_array))
+    assert all(geoms == retour)

rust/geoarrow/src/io/geozero/api/mod.rs

@@ -1,5 +1,3 @@
-mod ewkb;
 mod wkt;
 
-pub use ewkb::FromEWKB;
 pub use wkt::FromWKT;

rust/geoarrow/src/io/geozero/mod.rs

@@ -6,7 +6,7 @@ pub(crate) mod array;
 mod scalar;
 pub(crate) mod table;
 
-pub use api::{FromEWKB, FromWKT};
+pub use api::FromWKT;
 pub use array::{
     ToLineStringArray, ToMixedArray, ToMultiLineStringArray, ToMultiPointArray,
     ToMultiPolygonArray, ToPointArray, ToPolygonArray,

rust/geoarrow/src/io/wkb/api.rs

@@ -11,7 +11,9 @@ use crate::trait_::ArrayAccessor;
 use crate::NativeArray;
 use arrow_array::OffsetSizeTrait;
 
-/// An optimized implementation of converting from ISO WKB-encoded geometries.
+/// An optimized implementation of converting from WKB-encoded geometries.
+///
+/// This supports either ISO or EWKB-flavored data.
 ///
 /// This implementation performs a two-pass approach, first scanning the input geometries to
 /// determine the exact buffer sizes, then making a single set of allocations and filling those new
@@ -176,7 +178,9 @@ impl FromWKB for Arc<dyn ChunkedNativeArray> {
     }
 }
 
-/// Parse an ISO [WKBArray] to a GeometryArray with GeoArrow native encoding.
+/// Parse a [WKBArray] to a GeometryArray with GeoArrow native encoding.
+///
+/// This supports either ISO or EWKB-flavored data.
 ///
 /// Does not downcast automatically
 pub fn from_wkb<O: OffsetSizeTrait>(