Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-849: create profile multi segement gpx #1125

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Nov 12, 2024

@sommerfe sommerfe self-assigned this Nov 12, 2024
Copy link

cypress bot commented Nov 12, 2024

web-mapviewer    Run #3837

Run Properties:  status check passed Passed #3837  •  git commit a5cc29ec0c: PB-849: show segments multi segment file
Project web-mapviewer
Branch Review feat-pb-849-profile-multi-segment-gpx
Run status status check passed Passed #3837
Run duration 04m 05s
Commit git commit a5cc29ec0c: PB-849: show segments multi segment file
Committer Felix Sommer
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 212
View all changes introduced in this branch ↗︎

@sommerfe sommerfe force-pushed the feat-pb-849-profile-multi-segment-gpx branch from cb35a68 to d56f7c0 Compare November 12, 2024 14:52
@sommerfe sommerfe marked this pull request as ready for review November 12, 2024 15:02
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will have to split segments, and ask for each one of them a different profile. Without that, the profile service will fill the blank with a straight line.

Here's an example : https://sys-map.dev.bgdi.ch/preview/feat-pb-849-profile-multi-segment-gpx/index.html#/map?lang=en&center=2595517.76,1205066.81&z=5.359&bgLayer=ch.swisstopo.pixelkarte-grau&topic=ech&layers=ch.astra.veloland@features=890.00&featureInfo=default

if you hover over the profile chart, you'll see at the end that it follows a straight line from the last point of the big loop to the beginning of the smaller one. It would make more sense to add some kind of pagination to the profile, with segments count or something like that
image

@sommerfe sommerfe force-pushed the feat-pb-849-profile-multi-segment-gpx branch 3 times, most recently from 9d9126f to 0f640f6 Compare November 15, 2024 10:05
@sommerfe sommerfe force-pushed the feat-pb-849-profile-multi-segment-gpx branch from 0f640f6 to e06c4ba Compare November 15, 2024 10:31
@sommerfe sommerfe requested a review from pakb November 15, 2024 10:31
@sommerfe sommerfe force-pushed the feat-pb-849-profile-multi-segment-gpx branch from e06c4ba to a5cc29e Compare November 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants