PB-1120: Remove error key when the extent is valid.

[ismailsunni]

Test link

[cypress]

web-mapviewer    Run #3786

Run Properties:   Passed #3786  •  e2f6721bb3: PB-1120: Remove only related error message.

Project	web-mapviewer
Branch Review	pb-1120-layer-error-are-not-emptied
Run status	Passed #3786
Run duration	05m 17s
Commit	e2f6721bb3: PB-1120: Remove only related error message.
Committer	Ismail Sunni
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	21
Skipped	0
Passing	211
View all changes introduced in this branch ↗︎

[ltkum]

@pakb just merged a monster of a pull request in which all error keys are replaced with error message. This looks correct, but it would be good to rebase and adapt to the new way of handling errors :)

still needs some fixing

[ismailsunni]

Thanks @ltkum @pakb I have used the new way to add error to a layer. I also modified the removeErrorMessage because it won't work as expected if we use Set().delete

[ltkum]

The reason why we need to change the way we remove error messages is because within the set, the reference to the object won't be the same (we create a new object each time we update the layers). Another way to solve this would be to have the error messages be instanced only once, but I like your approach, as we won't always be sure in the future that we receive the exact same instance of a message.

looks good to me :)