PB-877: add swisssearch legacy url limit attribute

[sommerfe]

Test link

[cypress]

web-mapviewer    Run #3796

Run Properties:   Passed #3796  •  2a822acfdf: PB-877: fix tests

Project	web-mapviewer
Branch Review	feat-pb-877-add-swisssearch-legacy-url-limit-attribute
Run status	Passed #3796
Run duration	03m 52s
Commit	2a822acfdf: PB-877: fix tests
Committer	Felix Sommer
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	21
Skipped	0
Passing	212
View all changes introduced in this branch ↗︎

[ltshb]

I've two comprehension question that should be at least documented on the PR description:

• Why removing the swisssearch url parameter when it has been entered by the user ? What is the advantage of this ? If I read the ticket associated with this PR, the only issue that we have is that when a user is entering a search text in the search bar the swisssearch is set, so the changes should be very straight forward by not syncing store to url param, but only url param to store.
• Why adding this strange limit support and how it works ? from where does it come from ? is it documented ? I could not find anything in ticket related to this ? Based on the PR title it is a legacy attribute so it should be in the legacy url param parser or has it been decided to keep this as official ?
  Also the PR title only reflect the limit attribute but not the changes asked in ticket.

[ltshb]

I've just seen that this PR contains also #1084 this answer partly my questions above, you should base this PR to #1084 this would ease review and understanding, but then pay attention when merging to merge first #1084 and then rebase this one to develop before merging.

[ltshb]

See comment in ticket, I think this needs some refinement on how to do it.

Changes were made

[pakb]

Some small things to fix, and good to go