PB-722 : Cesium rework #1086
Open
PB-722 : Cesium rework #1086
+1,855
−3,493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-722-cesium-rework
|
| Run status |
|
| Run duration | 04m 36s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
211
|
| View all changes introduced in this branch ↗︎ | |
and get rid of the ol-cesium copy we have
like with OL, keeping all the logic for each group isolated from the main component
As refs on child component in the context of Composition API don't give the HTML element anymore, I had to export the size of the MapPopover component in its defineExpose (CesiumPopover needs to know the width of the popover to place it correctly)
that fixes the issues we had with touch device navigation in 3D
one for the camera management, one for mouse/click interaction transforming the whole thing into Composition API in the process
labels weren't showing without it
and fly to new camera position only if different than current position (should remove the little extra "move" that could be felt at the end of a mouse drag)
Rework of the GeoJSON style converter, so that it can deal with triangle/square (any non-circle) shapes by using the OL icon generator we already have in the code. Adding support for opacity for all 3 types of layers (GeoJSON, KML and GPX) Clamping internal KMLs (from the drawing module) to the ground for better readability. keeping external non-clamped, so that they may give use the height (z coordinate). We do not use this z axis on drawing, so it makes sense that we clamp our stuff to the ground.
pakb
force-pushed
the
fix-PB-722-cesium-rework
branch
from
e2f9fc2
to
bf2e5af
Compare
now using the viewer dataSources instead of loading everything in the scene's primitives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the whole thing into Composition API, and fixing / improving many things in the process
I tried to apply the same logic as what we did with all OpenLayers component, naming them as their OL equivalents.
The only thing I found hard to do the same was camera and click/interaction management. As we have to wait for some condition to be met before initializing (Mercator) adding these two as composable was not ideal, as they also had to have this logic. So instead I've created components that are added when the viewer is created.
I took the opportunity to remove our shallow copy of
ol-cesiumthat was there to translate GeoJSON style into Cesium equivalent, and wrote something tailor made for us. I tested with Meteoschweiz layers, don't hesitate to try all the GeoJSON you know!Test link