-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-856 : add a style selector for KML in layer settings #1047
base: develop
Are you sure you want to change the base?
Conversation
web-mapviewer Run #3749
Run Properties:
|
Project |
web-mapviewer
|
Branch Review |
feat-PB-856-add-kml-style-selector
|
Run status |
Failed #3749
|
Run duration | 04m 45s |
Commit |
6352abed42: PB-856 : add a style selector for KML in layer settings
|
Committer | Pascal Barth |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
21
|
Skipped |
0
|
Passing |
210
|
View all changes introduced in this branch ↗︎ |
Tests for review
tests/cypress/tests-e2e/importToolFile.cy.js • 1 failed test • e2e/electron/mobile
Test | Artifacts | |
---|---|---|
The Import File Tool > Import KML file error handling |
Test Replay
Screenshots
|
0787d65
to
185ba67
Compare
src/modules/menu/components/activeLayers/MenuActiveLayersListItem.vue
Outdated
Show resolved
Hide resolved
src/modules/menu/components/activeLayers/MenuActiveLayersListItem.vue
Outdated
Show resolved
Hide resolved
185ba67
to
4b0ac63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pakb @hansmannj With styling and icons we might have a general issue with the introduction of babs icons, this PR (kml style selector) and PB-64 self-contained KML. I did not yet check and tested the babs icon for legacy icons, but did you think about this ? What happen if you open and edit a drawing with legacy babs icon ? |
4b0ac63
to
33725a6
Compare
33725a6
to
4cb37d2
Compare
@pakb @ismailsunni @ltshb : What's the status here? |
using this PR test link:
|
this enables users to opt-out of the default style (Google Earth like) we apply by default to external KML, and let them go back to the GeoAdmin (all red) style that was previously (on mf-geoadmin3) applied across the board. adding this choice to the layer URL extra attributes
4cb37d2
to
6352abe
Compare
this enables users to opt-out of the default style (Google Earth like) we apply by default to external KML, and let them go back to the GeoAdmin (all red) style that was previously (on mf-geoadmin3) applied across the board.
adding this choice to the layer URL extra attributes
Test link