Merge pull request #775 from dbrandenstein/oidc-dynamic-redirect

OIDC dynamic redirect
geo-engine · Feb 11, 2025 · 1c00387 · 1c00387
2 parents da1f5fa + bfe8b47
commit 1c00387
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
         "@angular/platform-browser-dynamic": "^19.1.3",
         "@angular/router": "^19.1.3",
         "@egjs/hammerjs": "^2.0.17",
-        "@geoengine/openapi-client": "0.0.19",
+        "@geoengine/openapi-client": "0.0.20",
         "codemirror": "~5.65.18",
         "d3": "~7.9.0",
         "dagre": "~0.8.5",

diff --git a/projects/common/src/lib/login/login.component.ts b/projects/common/src/lib/login/login.component.ts
@@ -59,8 +59,10 @@ export class LoginComponent implements OnInit, AfterViewInit, OnDestroy {
     }
 
     ngOnInit(): void {
+        const redirectUri = window.location.href.replace(/\/signin$/, this.loginRedirect());
+
         // check if OIDC login is enabled
-        this.userService.oidcInit().subscribe(
+        this.userService.oidcInit(redirectUri).subscribe(
             (idr) => {
                 this.oidcUrl = idr.url;
                 this.formStatus$.next(FormStatus.Oidc);
@@ -98,7 +100,7 @@ export class LoginComponent implements OnInit, AfterViewInit, OnDestroy {
 
     oidcLogin(): void {
         this.formStatus$.next(FormStatus.Loading);
-        window.location.href = this.oidcUrl + '&redirect_url=' + window.location.href.replace(/\/signin$/, this.loginRedirect());
+        window.location.href = this.oidcUrl;
     }
 
     login(): void {

diff --git a/projects/common/src/lib/user/user.service.ts b/projects/common/src/lib/user/user.service.ts
@@ -127,7 +127,7 @@ export class UserService {
 
         this.sessionInitialized = true;
 
-        if (oidcParams) {
+        if (oidcParams && sessionStorage.getItem('redirectUri')) {
             this.oidcLogin(oidcParams)
                 .pipe(first())
                 .subscribe(() => {
@@ -343,8 +343,14 @@ export class UserService {
         this.logoutCallback = callback;
     }
 
-    oidcInit(): Observable<AuthCodeRequestURL> {
-        return from(new SessionApi().oidcInit());
+    oidcInit(redirectUri: string): Observable<AuthCodeRequestURL> {
+        sessionStorage.setItem('redirectUri', redirectUri);
+
+        return from(
+            new SessionApi().oidcInit({
+                redirectUri: redirectUri,
+            }),
+        );
     }
 
     oidcLogin(request: {sessionState: string; code: string; state: string}): Observable<Session> {
@@ -353,12 +359,14 @@ export class UserService {
         new SessionApi()
             .oidcLogin({
                 authCodeResponse: request,
+                redirectUri: sessionStorage.getItem('redirectUri')!,
             })
             .then((response) => {
                 const session = this.sessionFromDict(response);
                 this.session$.next(session);
                 result.next(session);
                 result.complete();
+                sessionStorage.removeItem('redirectUri');
             })
             .catch((error) => result.error(error));
 

diff --git a/projects/core/src/lib/users/oidc/oidc.component.ts b/projects/core/src/lib/users/oidc/oidc.component.ts
@@ -44,7 +44,7 @@ export class OidcComponent implements OnInit, OnDestroy {
             this.pendingLoginRequest = true;
             this.loginDisabled.next(true);
             this.loginSubscription = this.userService
-                .oidcInit()
+                .oidcInit(window.location.href)
                 .pipe(
                     first(),
                     finalize(() => {

diff --git a/projects/dashboards/esg-indicator-service/src/app/login/login.component.ts b/projects/dashboards/esg-indicator-service/src/app/login/login.component.ts
@@ -56,8 +56,10 @@ export class LoginComponent implements OnInit, AfterViewInit, OnDestroy {
     }
 
     ngOnInit(): void {
+        const redirectUri = window.location.href.replace(/\/signin$/, '/dashboard');
+
         // check if OIDC login is enabled
-        this.userService.oidcInit().subscribe(
+        this.userService.oidcInit(redirectUri).subscribe(
             (idr) => {
                 this.oidcUrl = idr.url;
                 this.formStatus$.next(FormStatus.Oidc);

diff --git a/projects/dashboards/gfbio/src/app/app.component.ts b/projects/dashboards/gfbio/src/app/app.component.ts
@@ -273,7 +273,7 @@ export class AppComponent implements OnInit, AfterViewInit {
         const state = params.get('state');
 
         let login;
-        if (sessionState && code && state) {
+        if (sessionState && code && state && sessionStorage.getItem('redirectUri')) {
             login = this.userService.oidcLogin({sessionState, code, state}).pipe(first());
         }