Fix wrong ABI detection for MIPS64 Musl toolchains #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the tuple mips64*-musl sets a n32 abi which isn't supported by Musl and causes numerous issues, so this simple fix will force a n64 abi. Signed-off-by: Ian Jordan <[email protected]>
floppym
approved these changes
Jun 16, 2023
Sorry I missed this thread in my emails and github notifications. Kumba and I have looked into this and Kumba proved n32 musl works with crossdev so it looks like the musl docs are incorrect here. Let's hold off until I've 100% proven it doesn't work on real hardware once my mips device gets kernel support for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tuple mips64*-musl sets a n32 abi which isn't supported by Musl and causes numerous issues, so this simple fix will force a n64 abi.
Signed-off-by: Ian Jordan [email protected]