Add support for overriding the profile and install baselayout for merged-usr #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such as -C, which means --clean for crossdev rather than NO_COLOR. Signed-off-by: James Le Cuirot <[email protected]>
Closes: https://bugs.gentoo.org/748975 Closes: gentoo#22 Signed-off-by: James Le Cuirot <[email protected]>
It's almost never what users want and causes issues even if they change the profile later. Closes: https://bugs.gentoo.org/748975 Signed-off-by: James Le Cuirot <[email protected]>
|
Bah, |
crossdev environments need to support merged-usr now, especially now that the profile can be selected. The logic around this is messy and best handled by the baselayout package when it is supported by the arch. This package now gets installed immediately before binutils. It means a few small extra files get installed, but that's a small price to pay. We could INSTALL_MASK them, but that would just add more complexity. Signed-off-by: James Le Cuirot <[email protected]>
|
This is still breaking for riscv. I think it's because it's getting the ABI list from multilib.eclass rather than the profile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #22, which added the initial support for the overriding the profile. This extends that work, adding a warning if you don't select a profile, and installing baselayout to get the right layout with merged-usr profiles.
It also includes a couple of other small improvements.
Unfortunately, merged-usr layouts will still suffer from gentoo/gcc-patches#8 when the sysroot is changed from the default. The embedded profile with a split-usr profile is still the default, changing the sysroot is an advanced use case, and I've managed to work around the issue with cross-boss, so I think it's okay to merge these changes now.