-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added target to isObjectPerceived #10
base: main
Are you sure you want to change the base?
Conversation
else | ||
{ | ||
setOutput("object_id", received_msg_); | ||
return BT::NodeStatus::SUCCESS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated line
|
||
|
||
if (received_msg_ == "") | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do a colcon test, the linter would make the isolated { in one line
@@ -63,7 +63,7 @@ isObjectPerceived::tick() | |||
//TODO:: make sure that string comparison is right!!!!!! | |||
for (auto edge : edges_by_data) | |||
{ | |||
if (target == ros2_knowledge_graph::to_string(edge)) | |||
if (target == edge.target_node_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint
Keeps running till the specified target is perceived.