Fix deprecation #636
Merged
Fix deprecation #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated, replace with ``shutil.which``
tnowotny
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of minor issues:
distutilsand hencedistutils.spawn.find_executableis deprecated, replace withshutil.which. Only reason we didn't do this before was because GeNN 4.X tried to maintain Python 2.7 compatibility.setuptools74 gets rid of the module of Visual Studio magic helpers which we use to find the compiler on Windows. For now have just restricted setuptools to < 74 (This also affects Brian brian2 import fails with latest setuptools (version 74.0.0) brian-team/brian2#1557)