Implement Display for Error #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cccs-sadugas
force-pushed
the
display_for_error
branch
from
69449b6 to
85e5c29
Compare
gendx
requested changes
Jul 15, 2020
There was a problem hiding this comment.
I think it would also be useful to implement the std::error::Error trait (essentially implementing the source() method to return Some(e) in case of IO error and None otherwise).
Useful for printing out error messages to users.
Makes sense because this is an error value in a Result<T, E>.
cccs-sadugas
force-pushed
the
display_for_error
branch
from
85e5c29 to
5d1e8ac
Compare
gendx
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Useful for printing out error messages to users.
This is needed by future versions of #51 .
Testing Strategy
This pull request was tested by...
.lzma,.lzma2,.xzfiles).Already covered by existing test cases