-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved pusher value in message #383
base: main
Are you sure you want to change the base?
Conversation
|
||
assert_eq!(localizer.get_value("12000", 8, Format::Short, locale).unwrap(), "0.00012"); | ||
assert_eq!(localizer.get_value("0", 8, Format::Short, locale).unwrap(), "0.00"); | ||
assert_eq!(localizer.get_value("1", 8, Format::Short, locale).unwrap(), "0.01"); // Invalid? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many values are invalid, need to have better unit test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did split code into BigNumberLocalizer
to separate from BigNumberFormatter
which is in theory should be just ValueFormatter
or ValueDecoder
|
||
pub enum Format { | ||
Short, | ||
Medium, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add full
Improved value formatting for pusher messages