feat: stargate integration #374
Open
+830
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemcoder21
reviewed
Jan 14, 2025
gemcoder21
reviewed
Jan 16, 2025
0xh3rman
reviewed
Jan 16, 2025
Co-authored-by: 0xh3rman <[email protected]>
Co-authored-by: 0xh3rman <[email protected]>
0xh3rman
reviewed
Jan 17, 2025
0xh3rman
approved these changes
Jan 17, 2025
gemcoder21
reviewed
Jan 17, 2025
| async fn fetch_quote_data(&self, quote: &SwapQuote, _provider: Arc<dyn AlienProvider>, _data: FetchQuoteData) -> Result<SwapQuoteData, SwapperError> { | ||
| let pool = self.client.get_pool_by_asset_id("e.request.from_asset)?; | ||
| let route_data: StargateRouteData = serde_json::from_str("e.data.routes.first().unwrap().route_data).map_err(|_| SwapperError::InvalidRoute)?; | ||
| let send_calldata = self.client.send( |
There was a problem hiding this comment.
Suggested change
| let send_calldata = self.client.send( | |
| let calldata = self.client.send( |
| &Address::from_str(route_data.refund_address.as_str()).unwrap(), | ||
| ); | ||
|
|
||
| let mut value_to_send = route_data.fee.nativeFee; |
There was a problem hiding this comment.
I would recommend using:
let fee = if quote.request.from_asset.is_native() { route_data.fee.nativeFee } else { 0 }
let value = route_data.send_param.amountLD + fee
There was a problem hiding this comment.
Always try to avoid using mut
| } | ||
|
|
||
| let pool = self.client.get_pool_by_asset_id(&request.from_asset)?; | ||
| let mut send_param = self.client.build_send_param(request)?; |
There was a problem hiding this comment.
can we avoid using mut? create function that would calculate all the data for you instead and return a struct
There was a problem hiding this comment.
Here we have 2 steps:
Build initial send params and request oft quote
Update initial send params and request send quote
I improved code style based on comment
| let from_asset = &request.from_asset; | ||
| let to_asset = &request.to_asset; | ||
|
|
||
| if from_asset.chain == to_asset.chain { |
There was a problem hiding this comment.
no need check chains, we have function on the higher level to check for this
dav3yblaz3
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#310
Bridge token transfer
USDT (BNB) -> USDT (OP)
https://bscscan.com/tx/0x110134e6abbd89b5133aa49c6be00f0e8f60eb9cc4d8841f2d3ee42ab82f5528
ETH (Base) -> ETH (OP)
https://basescan.org/tx/0x7ce7a2ff0fb0098810110d8321a498377d0746b147c8020d46620003462bf363
USDC (OP) -> USDC (Avalance)
https://optimistic.etherscan.io/tx/0x38429bdd5345639d074b1bc5c39e7550e3ab1684eb18e7087582ec0be8ea3949
Add referral fee (via compose)
Add unit / integration test