chore: re-write existing-browser to typescript #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowusr
force-pushed
the
users/shadowusr/TESTPLANE-433.re-write-to-typescript-1
branch
from
7fb55f8 to
2019d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done
A reminder on why unit tests need fixing after migrating to TS: since we are using SWC, it transforms modules into non-editable getters, which cannot be stubbed in a
sinon.stub(module, "method")manner. The only way to stub such modules is via proxyquire. In the future we'll migrate to vitest which has more advanced&convenient ways of doing this.