feat(reporters): jest html reporter #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 30, 2025 07:17
shadowusr
reviewed
Jan 30, 2025
There was a problem hiding this comment.
PR супер! 🔥 Круто, что получилось быстро поддержать jest и расширить возможности html-reporter!
В целом PR почти готов, есть ряд минорных замечаний.
Из критичного:
- Нужна дока с примерами, как подключить, как использовать, как менять настройки в конфиге, как смотреть отчет, т.е. базовые сценарии
- В идеале тесты в директории e2e, но это уже как по времени будет получаться, не обязательно
- Ряд опечаток/случайных ошибок в коде
added 5 commits
January 31, 2025 13:01
mordvinx
changed the title
mordvinx
changed the title
shadowusr
approved these changes
Jan 31, 2025
| In our case, there are no special differences, but for convenience, all the necessary information is provided below. | ||
|
|
||
| ## Minimal configuration | ||
| To connect the reporter, just go to jest.config.specify in the js file: |
There was a problem hiding this comment.
Не хватает шага с установкой (хотя он и очевидный, но думаю не помешает)
|
|
||
| After the report is generated, it must be distributed from the local server. | ||
|
|
||
| This requires the serve library, a package for quick and easy maintenance of static files. It allows you to turn the current working directory into a virtual server where you can open HTML, CSS, JavaScript files and other static assets in the browser. |
There was a problem hiding this comment.
Думаю, не стоит писать, что serve — требование (requires). Просто написать, что нужен любой какой-нибудь сервер, например, serve. Ну и заодно уточнить, что если отчет выложен допустим на S3, то ничего не надо
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom reporter for Jest.
How to use: