Fix visibility_time format to match its value (both in seconds). #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rwise TimeDelta assumes a default format of 'jd', which will not match the value and visibility fraction factor in observation scores will be wrong.
|
Hey Mark! I tried the fix and it looks like the values are bigger now. Can you update the branch so we can merge it? I'll run the redis values after that. |
|
Hi Sergio, I'm not certain if I did what you needed. If you need more let me know (I'm not that familiar with the workflow I should be doing). |
MarkEverett
had a problem deploying
to
schedule-staging
GitHub Actions
Failure
MarkEverett
had a problem deploying
to
schedule-staging
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise TimeDelta assumes a default format of 'jd', which will not match the value and visibility fraction factor in observation scores will be wrong.
This fix has not been tested because the calculated values have been used to fill the redis database, which I can't alter. My understanding is that the redis database must be refilled using this fix. Then we may have the observation scores calculated correctly.