Skip to content

Commit

Permalink
Merge pull request #47 from gemini-hlsw/GSCHED-735
Browse files Browse the repository at this point in the history
JSON parse not required
  • Loading branch information
dngomez authored Aug 23, 2024
2 parents c359640 + d8d4f80 commit 8889a63
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
5 changes: 2 additions & 3 deletions src/components/Results/NightPlanSummary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@ export default function NightPlanSummary({
nightConditions: NightConditions;
nightTitle: string;
}) {
// const conditions = JSON.parse(planConditions)
const completion = JSON.parse(nightState.completionFraction);
const completion = nightState.completionFraction;
return (
<div className="summary">
<h4 className="title">Night Plan {nightTitle}</h4>
<div className="body">
<div>Timeloss: {nightState.timeLoss}</div>
<div>Timeloss: {JSON.stringify(nightState.timeLoss)}</div>
<div>Cloud Cover: {nightConditions.cc}</div>
<div>Image Quality: {nightConditions.iq}</div>
{/* <Tag icon="pi pi-cloud">
Expand Down
7 changes: 3 additions & 4 deletions src/components/Results/TimeEntry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,13 @@ export default function TimeEntry({
}
};

const programCompletion = (programCompletion: string) => {
const jProgCompletion = JSON.parse(programCompletion);
const programCompletion = (programCompletion: { [key: string]: number }) => {
var pc = [];

for (var p in jProgCompletion) {
for (var p in programCompletion) {
pc.push({
progId: p,
completion: jProgCompletion[p],
completion: programCompletion[p],
});
}
return pc;
Expand Down
6 changes: 3 additions & 3 deletions src/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ export interface Visit {
}

export interface NightStats {
timeLoss: string;
timeLoss: { faults: number; unschedule: number; weather: number };
planScore: number;
nToos: number;
completionFraction: string;
programCompletion: string;
completionFraction: number[];
programCompletion: { [key: string]: number };
}

0 comments on commit 8889a63

Please sign in to comment.