Implement target swap/restore #158
Conversation
hugo-vrijswijk
force-pushed
the
sc-3283-implement-target-swap
branch
2 times, most recently
from
6636e26
to
7de34d5
Compare
| @@ -0,0 +1,98 @@ | |||
| import { useCanEdit } from '@/components/atoms/auth'; | |||
There was a problem hiding this comment.
When reviewing, mainly look at this file
hugo-vrijswijk
force-pushed
the
sc-3283-implement-target-swap
branch
from
7de34d5
to
3ef2da5
Compare
| @@ -23,17 +23,17 @@ export function OdbImport() { | |||
| const rotator = useRotator().data?.rotator; | |||
|
|
|||
| function updateObs() { | |||
| updateConfiguration({ | |||
| void updateConfiguration({ | |||
There was a problem hiding this comment.
Just to learn 😅
Why is this void needed?
There was a problem hiding this comment.
Good question! I updated the linting rules to not allow "floating promises" which are promise-returning functions that are never awaited. It's a great rule that can catch bugs, but in cases like these where it's an event handler we have to "discard" the promise (void)
There was a problem hiding this comment.
Awesome, thank you for the explanation.
src/Helpers/toast.tsx
Outdated
There was a problem hiding this comment.
Awesome, much better solution. It is like using shadcn/ui.
| const [swapTarget, { loading: swapLoading }] = useSwapTarget(); | ||
| const [restoreTarget, { loading: restoreLoading }] = useRestoreTarget(); | ||
|
|
||
| const { data: instrumentData, loading: instrumentLoading } = useInstrument(); |
There was a problem hiding this comment.
I think this will cause the same problem we had in the tests last Friday, where instrument was always undefined, because we are not passing the required variables name, issPort and wfs.
hugo-vrijswijk
force-pushed
the
sc-3283-implement-target-swap
branch
from
3ef2da5
to
2a90231
Compare
hugo-vrijswijk
force-pushed
the
sc-3283-implement-target-swap
branch
from
2a90231
to
847930d
Compare
useToasthook that doesn't require adding a toast and ref for each component