-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error policies, huge refactors, and a lot of other breaking changes #480
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
504d73e
first version of ErrorPolicy
rpiaggio 9ca0690
new approach
rpiaggio 35dd12b
refactor
rpiaggio ec575fb
update demo
rpiaggio 332941f
tests, AsObject
rpiaggio 5720599
adjust code
rpiaggio 6ef03c2
bump base version, fix Demo
rpiaggio f895749
organize imports in tests
rpiaggio 63e16b3
remove comments
rpiaggio dd0890e
more organize imports
rpiaggio f59643b
limit list size in tests
rpiaggio 6c811d6
scalafmt
rpiaggio 8c69d62
remove commented code
rpiaggio 4104ce3
address PR comments
rpiaggio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| // Copyright (c) 2016-2023 Association of Universities for Research in Astronomy, Inc. (AURA) | ||
| // For license information see LICENSE or https://opensource.org/licenses/BSD-3-Clause | ||
|
|
||
| package clue | ||
|
|
||
| import cats.MonadThrow | ||
| import cats.data.Ior | ||
| import cats.effect.Sync | ||
| import cats.syntax.all._ | ||
| import clue.model.GraphQLCombinedResponse | ||
| import clue.model.GraphQLDataResponse | ||
| import clue.model.GraphQLErrors | ||
|
|
||
| sealed trait ErrorPolicy { | ||
| type ReturnType[D] | ||
|
|
||
| def processor[D]: ErrorPolicyProcessor[D, ReturnType[D]] | ||
| } | ||
|
|
||
| sealed trait ErrorPolicyProcessor[D, R] { | ||
| def process[F[_]: Sync](result: GraphQLCombinedResponse[D]): F[R] | ||
| } | ||
|
|
||
| object ErrorPolicy { | ||
| protected sealed trait Distinct[D] extends ErrorPolicyProcessor[D, D] { | ||
| protected def processData[F[_]: Sync, D](data: D): F[D] = Sync[F].delay(data) | ||
| protected def processErrors[F[_]: MonadThrow, D](errors: GraphQLErrors): F[D] = | ||
| MonadThrow[F].raiseError(ResponseException(errors)) | ||
| } | ||
|
|
||
| object IgnoreOnData extends ErrorPolicy { | ||
| type ReturnType[D] = D | ||
|
|
||
| def processor[D]: ErrorPolicyProcessor[D, D] = new Distinct[D] { | ||
| def process[F[_]: Sync](result: GraphQLCombinedResponse[D]): F[D] = | ||
| result match { | ||
| case Ior.Left(errors) => processErrors(errors) | ||
| case Ior.Right(data) => processData(data) | ||
| case Ior.Both(_, data) => processData(data) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| object RaiseAlways extends ErrorPolicy { | ||
| type ReturnType[D] = D | ||
|
|
||
| def processor[D]: ErrorPolicyProcessor[D, D] = new Distinct[D] { | ||
| def process[F[_]: Sync](result: GraphQLCombinedResponse[D]): F[ReturnType[D]] = | ||
| result match { | ||
| case Ior.Left(errors) => processErrors(errors) | ||
| case Ior.Right(data) => processData(data) | ||
| case Ior.Both(errors, _) => processErrors(errors) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| object ReturnAlways extends ErrorPolicy { | ||
| type ReturnType[D] = GraphQLCombinedResponse[D] | ||
|
|
||
| def processor[D]: ErrorPolicyProcessor[D, GraphQLCombinedResponse[D]] = | ||
| new ErrorPolicyProcessor[D, GraphQLCombinedResponse[D]] { | ||
|
|
||
| def process[F[_]: Sync](result: GraphQLCombinedResponse[D]): F[ReturnType[D]] = | ||
| Sync[F].delay(result) | ||
| } | ||
| } | ||
|
|
||
| object RaiseOnNoData extends ErrorPolicy { | ||
| type ReturnType[D] = GraphQLDataResponse[D] | ||
|
|
||
| def processor[D]: ErrorPolicyProcessor[D, GraphQLDataResponse[D]] = | ||
| new ErrorPolicyProcessor[D, GraphQLDataResponse[D]] { | ||
|
|
||
| def process[F[_]: Sync](result: GraphQLCombinedResponse[D]): F[ReturnType[D]] = | ||
| result match { | ||
| case Ior.Left(errors) => MonadThrow[F].raiseError(ResponseException(errors)) | ||
| case Ior.Right(data) => Sync[F].delay(GraphQLDataResponse(data, none, none)) | ||
| case Ior.Both(errors, data) => | ||
| Sync[F].delay(GraphQLDataResponse(data, errors.some, none)) | ||
| } | ||
|
|
||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need
Sync? Can thedelays below just be pure, in which caseApplicativeThrowis all that is needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds right, good catch too.