resources: Fixed some errors and added some extra documentation #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a valid script in Gem5 In the last example configs/example/gem5_library/local-resource-example.py. I am not sure if it's a valid script in Gem5 codebase. Also added an example of directly using the environment variable
Pretentiousness
changed the title
|
@Harshil2107 @BobbyRBruce can you check if this is accurate? |
Pretentiousness
changed the title
|
@BobbyRBruce can you check this PR. |
Pretentiousness
changed the title
Harshil2107
approved these changes
Sep 23, 2024
BobbyRBruce
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if local-resource-example.py is a valid script in Gem5
In the last example configs/example/gem5_library/local-resource-example.py. I am not sure if it's a valid script in Gem5 codebase. Also added an example of directly using the environment variable