Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: Add example about increasing disk image size in documentation #65

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

Harshil2107
Copy link
Contributor

No description provided.

@mahyarsamani
Copy link
Contributor

Thanks for the update. I would the value of disk_size in .hcl as a function of the other parameters. This is because the 2nd partition size is the size that they will have access to, not the disk_size in .hcl.

Copy link
Contributor

@erin-le erin-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some small comments, it looks good.

type: disk
id: disk-vda
- device: disk-vda
size: 1048576
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size: 1048576
size: 1048576 #size of boot partition

type: partition
id: partition-0
- device: disk-vda
size: 9997902848
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size: 9997902848
size: 9997902848 #size of main partition. Updated with the value calculated above.

type: disk
id: disk-vda
- device: disk-vda
size: 564133888
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size: 564133888
size: 564133888 #size of boot partition


2. **Calculate Partition Sizes for `user-data`:**
- Convert the disk size to bytes: `10000 MB = 10,000,000,000 bytes`.
- Subtract the sizes of the boot partition:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these sizes shouldn't be modified by the user, it might be good to add a line like this:

Suggested change
- Subtract the sizes of the boot partition:
- Subtract the sizes of the boot partition. These sizes shouldn't be modified.

type: format
id: format-0
- device: disk-vda
size: 9434817536
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size: 9434817536
size: 9434817536 #size of main partition. Updated with the value calculated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants