Separate LSE into LqSE (liquefaction) and LsSE (landslide) #10385
Conversation
| @@ -317,7 +317,7 @@ def ASH(): | |||
|
|
|||
|
|
|||
| # secondary IMTs | |||
| sec_imts = 'Disp DispProb LiqProb LiqOccur LSE PGDMax LSD PGDGeomMean LsProb'.split() | |||
| sec_imts = 'Disp DispProb LiqProb LiqOccur LqSE LsSE PGDMax LSD PGDGeomMean LsProb'.split() | |||
There was a problem hiding this comment.
If we are using Lq for liquefaction, can we also change LiqProb and LiqOccur to LqProb and LqOccur to be consistent?
| @@ -227,7 +227,7 @@ class ZhuEtAl2017LiquefactionCoastal(SecondaryPeril): | |||
| to binary output via the predefined probability threshold. | |||
| """ | |||
|
|
|||
| outputs = ["LiqProb", "LiqOccur", "LSE"] | |||
| outputs = ["LiqProb", "LiqOccur", "LqSE"] | |||
There was a problem hiding this comment.
If we are using Lq for liquefaction, can we also change LiqProb and LiqOccur to LqProb and LqOccur to be consistent?
| @@ -319,7 +319,7 @@ class RashidianBaise2020Liquefaction(SecondaryPeril): | |||
| to binary output via the predefined probability threshold. | |||
| """ | |||
|
|
|||
| outputs = ["LiqProb", "LiqOccur", "LSE"] | |||
| outputs = ["LiqProb", "LiqOccur", "LqSE"] | |||
There was a problem hiding this comment.
If we are using Lq for liquefaction, can we also change LiqProb and LiqOccur to LqProb and LqOccur to be consistent?
| @@ -378,7 +378,7 @@ class AllstadtEtAl2022Liquefaction(SecondaryPeril): | |||
| to binary output via the predefined probability threshold. | |||
| """ | |||
|
|
|||
| outputs = ["LiqProb", "LiqOccur", "LSE"] | |||
| outputs = ["LiqProb", "LiqOccur", "LqSE"] | |||
| @@ -348,13 +348,20 @@ def LiqOccur(): | |||
| return IMT('LiqOccur') | |||
|
|
|||
|
|
|||
| def LSE(): | |||
| def LqSE(): | |||
There was a problem hiding this comment.
Same comment as above regarding LiqProb() and LiqOccur() →LqProb() and LqOccur()
Also, @micheles probably no one noticed this until now, but if you check above, the return statement for the following IMT seems wrong..
def DispProb():
"""
Displacement probability
"""
return IMT('RSD595')
There was a problem hiding this comment.
Yes, I would have expected a return IMT('DispProb')
|
My plan would be to implement namespaces for the IMTs (i.e. the column names in gmf_data will become |
To clearly distinguish between the Liquefaction and Landslide Speatial Extent, the original imt (LSE) was divided into LqSE (for liquefaction) and LsSE (for landslides).