Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified RuptureGetter/2 #10217

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Simplified RuptureGetter/2 #10217

merged 1 commit into from
Dec 16, 2024

Conversation

micheles
Copy link
Contributor

@micheles micheles commented Dec 16, 2024

By saving the rupture records instead of the proxies and using len(records) as weight. Part of #10209. There is no change in performance for EUR:

# before
| operation-duration | counts | mean    | stddev | min    | max     | slowfac |
|--------------------+--------+---------+--------+--------+---------+---------|
| event_based        | 424    | 14.8517 | 37%    | 1.3335 | 30.6265 | 2.0622  |

# after
| operation-duration | counts | mean    | stddev | min    | max     | slowfac |
|--------------------+--------+---------+--------+--------+---------+---------|
| event_based        | 424    | 14.8577 | 37%    | 1.2998 | 30.8787 | 2.0783  |

@micheles micheles added this to the Engine 3.22.0 milestone Dec 16, 2024
@micheles micheles self-assigned this Dec 16, 2024
@micheles micheles merged commit 1ebf0f3 into master Dec 16, 2024
7 checks passed
@micheles micheles deleted the RuptureGetter branch December 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant