#84 | Add pull request template for standardized submissions #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleyna-yildizli
added
the
documentation
aleyna-yildizli
requested review from
mert-ayhan,
ferhatozcelik,
skarakasoglu,
meminkecik and
MerveSoftware
aleyna-yildizli
requested review from
agitrubard,
Ciklamert and
alpemreelmas
as code owners
aleyna-yildizli
changed the title
agitrubard
requested changes
Sep 23, 2024
| (Provide any additional context or comments related to this pull request. For example, discuss any potential impacts on other parts of the codebase, or mention any known issues.) | ||
|
|
||
| ### Screenshots (if applicable) | ||
| (Include screenshots of the changes if it affects the user interface. This helps reviewers understand the changes better.) |
There was a problem hiding this comment.
Burayı tamamen checklist olacak şekilde madde madde ayırmamız daha iyi olabilir. Issue'yu linklememize ihtiyaç kalmıyor çünkü Pull Request üzerinden ilişkilendiriyoruz. Ekran görüntüsü ihtiyacımız da olacağını sanmıyorum. O yüzden tamamen checklistlerden oluşacak şekilde düzenleyebilirsek çok daha kullanışlı olabilir.
Örneğin;
Checklist
Before submitting your pull request, ensure the following:
-
Title and Branch Naming Conventions:
- The pull request title follows the
standard: Pull Request Naming Conventions. - The branch name follows one of the conventions outlined in
the Branch Naming Conventions.
- The pull request title follows the
-
Local Testing:
- I have tested my changes locally on Postman, and they are working as expected.
-
Code Quality:
- The code is formatted according to the project's coding guidelines and style.
- The code has been reviewed to ensure its quality.
- The code does not contain any issues flagged by SonarLint.
-
Documentation:
- Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
-
Testing:
- Relevant unit tests have been written and included.
- Relevant integration tests have been written and included.
-
Reviewers and Assignees:
- Default reviewers have been assigned to this pull request.
- Assignees have been added if necessary.
-
Labels and Associations:
- No specific actions are required in the Labels and Associations section for this pull request.
agitrubard
requested changes
Sep 23, 2024
agitrubard
requested review from
hnurr
and removed request for
ferhatozcelik
aleyna-yildizli
removed
the
documentation
agitrubard
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.