Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload the tutorial for the FastAPI search bot #8314

Merged
merged 19 commits into from
Feb 19, 2025

Conversation

deepbuzin
Copy link
Contributor

No description provided.

@edgedb-cla
Copy link

edgedb-cla bot commented Feb 6, 2025

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

Copy link

github-actions bot commented Feb 6, 2025

Docs preview deploy

❌ Docs preview deployment failed for commit ae0dca2:

https://edgedb-docs-4wnp8zvfp-edgedb.vercel.app

(Last updated: Feb 19, 2025, 19:35:08 UTC)

@1st1
Copy link
Member

1st1 commented Feb 8, 2025

I like the flow & style, but I feel we shouldn't mess with Google and beautiful soup and instead build this for some API. HN search API is one such option. We can look for some other publicly accessible search APIs. The HN one can be fun (and potentially we can make some stupid/fun demos).

Another thing: please transform this into the new-style two-column tutorial. I've just reviewed Scott's PR and from it I now know that it's easier to assess the flow that way.

@deepbuzin
Copy link
Contributor Author

Another thing: please transform this into the new-style two-column tutorial. I've just reviewed Scott's PR and from it I now know that it's easier to assess the flow that way.

Sure, will do. Still figuring out the whole RST business.

Copy link
Member

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave a note here that I previously wrote for Scott's PR (by the way, I don't have particularly strong feelings about it. I don't think using "we" is wrong or worse, but we might try to adopt a more instructive tone by using "you").

A note on "we" vs "you": I noticed the quickstart switches between the two, which is generally not a wrong practice, but I was thinking we should stick to one.

"We" is great for creating personal connections between the user and the company, but it's sometimes unclear what "we" refers to - is it user+author, the company, or the tool? I saw another argument somewhere against "we" that "you're not sitting with the author".

For example, if there's "now, we'll create a function", it can be unclear whether "we will" means there's a Gel tool that does this or it's metaphorically "we". In most cases "we" don't do these things - user "you" does. Or "we will create a migration to apply this schema" can make total sense in the context but if someones loses the context, they can think "gel (we) will create a migration to apply this schema".

I would use "we" only for introductions or summaries - "we'll walk you through...", "we covered", "we have a template app for you to clone" - i.e. in places where it make sense to refer to us (authors/company). And for all instructions we can go with "you" - "make sure you have ...", "(you) clone our repo", for example:

We'll create a proper data model for our application in the next step
can be
We will show you how to create a proper data model for your application in the next step
or
In the next step, you will create a proper data model for your application.

Switching to "you" for instructions takes away some of this connection vibe, but can make it more straight to the point. FWIW, "let's make ..." is fine as is.

Comment on lines 474 to 476
In case you need installation instructions, take a look at the :ref:`Quickstart
<ref_quickstart>`. Once Gel CLI is present in your system, initialize the
project like this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's tricky. Since we'll have the quickstart as a more extended tutorial, should we have separate, short setup guides to refer people in cases like this one?
cc @scotttrinh

Copy link
Contributor Author

@deepbuzin deepbuzin Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can point to a reference manual instead. Unless there're specific non-trivial considerations or instructions there, in which case I think there needs to be a short guide, sure.

the schema. By convention established in the LLM space, each message is going to
have a role in addition to the message content itself. We can also get Gel to
automatically keep track of message's creation time by adding a property callled
``timestamp`` and setting its :ref:`default value <ref_datamodel_props>` to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be created_at or created? Seem to be a more common way to name these things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should. I'm honestly not super happy with the naming across the app right now - there're too many things named search-something, there's search_terms.query vs search_query (not the same thing) and so on. I'd like to rename everything in-bulk later, once all the major things are out of the way.

@deepbuzin
Copy link
Contributor Author

I'll leave a note here that I previously wrote for Scott's PR (by the way, I don't have particularly strong feelings about it. I don't think using "we" is wrong or worse, but we might try to adopt a more instructive tone by using "you").
Switching to "you" for instructions takes away some of this connection vibe, but can make it more straight to the point.

I've been loosely applying this stylistic guidance throughout the tutorial. So the way I frame this it's less of us giving instructions to the reader, and more of us and the reader doing a thing together, and them learning in the process.

I think this makes the tutorial a little more engaging. And I think completing a tutorial should resemble the process of making a real app, which in turn isn't about piping a series of instruction together.

@deepbuzin deepbuzin force-pushed the tutorial-fastapi-gelai branch 3 times, most recently from b046459 to bafcb18 Compare February 18, 2025 06:41
@deepbuzin deepbuzin force-pushed the tutorial-fastapi-gelai branch from bafcb18 to 84b1720 Compare February 18, 2025 06:45
@deepbuzin deepbuzin merged commit ef45537 into new-gel-docs Feb 19, 2025
1 of 2 checks passed
@deepbuzin deepbuzin deleted the tutorial-fastapi-gelai branch February 19, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants