Fix inline functions substituting parameters from hidden nodes. #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwpark
requested review from
mmastrac,
aljazerzen and
msullivan
and removed request for
mmastrac
dnwpark
force-pushed
the
dont-inline-in-hidden
branch
from
64b1128 to
9b5ae32
Compare
|
Mark to-backport-6.x? |
msullivan
approved these changes
Feb 4, 2025
aljazerzen
approved these changes
Feb 4, 2025
dnwpark
added a commit
that referenced
this pull request
Feb 4, 2025
A function body may be a statement which contains references to a parent statement. Ensure that this parent's parameters are not substituted while inlining the function parameters.
msullivan
added
backported-6.x
msullivan
pushed a commit
that referenced
this pull request
Feb 4, 2025
A function body may be a statement which contains references to a parent statement. Ensure that this parent's parameters are not substituted while inlining the function parameters.
msullivan
pushed a commit
that referenced
this pull request
Feb 4, 2025
A function body may be a statement which contains references to a parent statement. Ensure that this parent's parameters are not substituted while inlining the function parameters.
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
A function body may be a statement which contains references to a parent statement. Ensure that this parent's parameters are not substituted while inlining the function parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8285
A function body may be a statement which contains references to a parent statement. Ensure that this parent's parameters are not substituted while inlining the function parameters.