Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EdgeDB server protocol in pgrust (currently unused) #8038

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Nov 26, 2024

Partial work towards landing the Rust frontend for EdgeDB:

  • Lands the prototype EdgeDB protocol + server implementation
  • Common server auth state machines are extracted to a new ServerAuth in gel_auth::handshake
  • Splits the auth library into "gel_auth" which we can use to replace some Cython code in a later patch
  • Cleans up unused deps for pgrust (and a few others scattered around)

This work was extracted from a branch implementing a Rust frontend (not included here)

@mmastrac mmastrac changed the title WIP: Implement EdgeDB protocol in pgrust (currently unused) Implement EdgeDB server protocol in pgrust (currently unused) Nov 26, 2024
@mmastrac mmastrac marked this pull request as ready for review November 26, 2024 20:00
@mmastrac mmastrac requested a review from fantix November 26, 2024 23:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It's a bit weird that we have the EdgeDB binary protocol under pgrust project.
  • We need to find a way to support both protocol v2.0 and v3.0 at the same time, at least for a while when people are connecting with old CLI/clients.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I will likely need to separate this in the future. For now, they share the codegen from the Postgres protocol and this will also need to be extracted.

This protocol is also 2.0 for now, but I'll need to ensure both are implemented.

@mmastrac mmastrac merged commit 300c4da into geldata:master Nov 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants