Replace headers with annotations in Parse/Execute #8037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
elprans
reviewed
Nov 25, 2024
elprans
approved these changes
Nov 26, 2024
msullivan
approved these changes
Nov 26, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take annotations (
dict[str, str]) instead of headers (dict[int, bytes]) in Parse/Execute messages.We forgot this in protocol 1.0 but had been ignoring headers, so it was fine until we're trying to make use of annotations now in EdgeDB 6.0. This change is a part of the binary protocol version 2.0 (EdgeDB 6.0a1 or nightlies before this PR will not work properly with annotations).