Add a debug flag to validate schema reflection #7958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the flag is set, after every DDL command we reintrospect the database and compare that to the in-meory schema. I've recently landed a few PRs fixing issues exposed by this. (IIRC, I also fixed a few earlier this year when I first wrote this PR.) Overall the system is pretty solid. Run it in CI once a day, since I think it is too slow to run all the time. Fixes #5169.
dnwpark
reviewed
Nov 4, 2024
| @@ -13,7 +13,8 @@ all: workflows/nightly.yml \ | |||
| workflows/tests-ha.yml \ | |||
| workflows/tests-pg-versions.yml \ | |||
| workflows/tests-patches.yml \ | |||
| workflows/tests-inplace.yml | |||
| workflows/tests-inplace.yml \ | |||
| workflows/tests-reflection.yml \ | |||
There was a problem hiding this comment.
minor but probably don't want to end with \
elprans
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the flag is set, after every DDL command we reintrospect the
database and compare that to the in-meory schema. I've recently landed
a few PRs fixing issues exposed by this. (IIRC, I also fixed a few
earlier this year when I first wrote this PR.) Overall the system is
pretty solid.
Run it in CI once a day, since I think it is too slow to run all the
time.
Fixes #5169.