Some more changes to reduce adjacent server flakes #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have never been happier in my life to have had a lint error. When I saw one test suite failed I assumed it was the flake again. |
1. Make worker threads (like net) not attempt new connections once the server has started shutting down. 2. Don't respond to messages that prompt updating database metadata for database's we don't have introspected anyway. 3. Mark a lot of worker tasks as being interruptable. When they weren't interruptable, server exit had to wait for them to exit, which they didn't always do. This caused connections to get held open. *Most* of the locally observable flakes I've been seeing were fixed by these changes, though I am still getting test_server_adjacent_database_propagation failures where it fails to connect to the newly create database. Still working on that.
msullivan
force-pushed
the
flake-fighting-1
branch
from
a591454 to
14564d3
Compare
elprans
approved these changes
Oct 23, 2024
fantix
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once the server has started shutting down.
metadata for database's we don't have introspected anyway.
weren't interruptable, server exit had to wait for them to
exit, which they didn't always do. This caused connections
to get held open.
Most of the locally observable flakes I've been seeing were fixed by
these changes, though I am still getting
test_server_adjacent_database_propagation failures where it fails to
connect to the newly create database. Still working on that.