Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow complex types as function params. #7759

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Allow complex types as function params. #7759

merged 1 commit into from
Sep 17, 2024

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Sep 17, 2024

Allow functions such as create function foo(x: A | B) -> int64 using (x.n);

@dnwpark dnwpark requested a review from msullivan September 17, 2024 16:42
@dnwpark dnwpark marked this pull request as ready for review September 17, 2024 16:42
msullivan
msullivan approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@dnwpark dnwpark merged commit 42f075b into master Sep 17, 2024
23 checks passed
@dnwpark dnwpark deleted the complex-type-args branch September 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnwpark @msullivan