Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few typos & add SNI in connection docs #7698

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Fix few typos & add SNI in connection docs #7698

merged 4 commits into from
Oct 4, 2024

Conversation

diksipav
Copy link
Contributor

@diksipav diksipav commented Aug 30, 2024 •
edited
Loading

I started updating connection docs with SNI, but realized it lacks info on some other connection options too.

I posted questions in Slack.

@diksipav diksipav marked this pull request as draft August 30, 2024 14:07
@diksipav diksipav requested review from 1st1 and scotttrinh August 30, 2024 14:09
scotttrinh
scotttrinh approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to land this without the other documentation, we can add that in a separate PR once we get all of the answers there.

@diksipav diksipav force-pushed the update-connection-docs branch from e642fb7 to 8055636 Compare September 3, 2024 10:32
@diksipav diksipav marked this pull request as ready for review September 3, 2024 18:52
@diksipav diksipav merged commit a6b9408 into master Oct 4, 2024
24 checks passed
@diksipav diksipav deleted the update-connection-docs branch October 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@scotttrinh scotttrinh scotttrinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diksipav @1st1 @scotttrinh