func cache: fix dropping extension with scalar type #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scalar types in extensions may defined `sql_type` thus not using `common.get_backend_name()`. Instead, here I think we should use `types.pg_type_from_scalar()` to cover more cases.
msullivan
approved these changes
Jul 16, 2024
…-scalar-type-in-ext
|
We do need a separate test here. The |
fantix
force-pushed
the
fix-func-cache-drop-scalar-type-in-ext
branch
from
c2c030c to
bd102fe
Compare
aljazerzen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Scalar types in extensions may defined `sql_type` thus not using `common.get_backend_name()`. Instead, here I think we should use `types.pg_type_from_scalar()` to cover more cases. Also fixed a flaky test.
aljazerzen
added
the
backported-5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalar types in extensions may define
sql_typethus not usingcommon.get_backend_name(). Instead, here I think we should usetypes.pg_type_from_scalar()to cover more cases.This is a follow up fix for d1b2c4d, captured in edgedb-js CI. This should've been caught by #7497, I'll double check why it didn't, and make sure either it does, or write a new test in this PR.
Manually tested for enum tuples as well as the pgvector
vectortype.