Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate spans in parsed SQL #7466

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Propagate spans in parsed SQL #7466

merged 2 commits into from
Jun 18, 2024

Conversation

aljazerzen
Copy link
Contributor

@aljazerzen aljazerzen commented Jun 17, 2024 •
edited
Loading

libpg_query emits a "location" fields that we already use and convert to our spans, but not on all nodes.

This PR make it so we now propagates spans from children into parents. It uses and improves existing span.SpanPropagator.

@aljazerzen
Copy link
Contributor Author

aljazerzen commented Jun 17, 2024 •
edited
Loading

Oh, to be able to update spans, I've removed the pgast.ImmutableBase, so nodes can be updated. I can revert that if there is a principled reason for it.

Edit: there is __ast_mutable_fields__

@aljazerzen aljazerzen requested a review from msullivan June 17, 2024 15:42
@aljazerzen aljazerzen merged commit 5eacce4 into master Jun 18, 2024
23 checks passed
@aljazerzen aljazerzen deleted the sql-propagate-spans branch June 18, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljazerzen @msullivan