Add a cfg::BranchConfig alias for cfg::DatabaseConfig #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I had remembered this *before* the 5.0 branch cut, I'd have made DatabaseConfig abstract and made BranchConfig a concrete subtype, which would have been generally more satisfying (actual type is BranchConfig, `IS` works with either), but this version is much safer to patch in. Some fixes were needed to make creating a standard library alias work.
aljazerzen
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I had remembered this before the 5.0 branch cut, I'd have made
DatabaseConfig abstract and made BranchConfig a concrete subtype,
which would have been generally more satisfying (actual type is
BranchConfig,
ISworks with either), but this version is much saferto patch in.
Some fixes were needed to make creating a standard library alias work.