Implement _run_and_rollback_retrying #6960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
commented
Mar 1, 2024
edb/testbase/connection.py
Outdated
Comment on lines
295
to
294
| class RawIteration(RawTransaction, Iteration): | ||
| async def _ensure_transaction(self): | ||
| self._started = True | ||
| await super()._ensure_transaction() | ||
|
|
||
|
|
||
| class Retry: | ||
| def __init__(self, connection): | ||
| def __init__(self, connection, raw=False): |
There was a problem hiding this comment.
Or should we make all our Iterations be RawTransactions?
There was a problem hiding this comment.
I ended up taking a different approach that allows Iteration to always contain nested transactions, but not to be in one
In general we should be using retrying transactions. Our isolated tests do retries at the outside, but non-isolated ones don't necessarily. Implement _run_and_rollback_retrying and use it some places that TransactionSerializationError flakes have been seen (in #6954 and in nightly CI). Honestly I don't really think that these places ought to be having TransactionSerializationErrors, but also it really is pretty required to do retries when using SERIALIZABLE, so we should start moving towards being more consistent about it.
msullivan
added a commit
that referenced
this pull request
Mar 7, 2024
In general we should be using retrying transactions. Our isolated tests do retries at the outside, but non-isolated ones don't necessarily. Implement _run_and_rollback_retrying and use it some places that TransactionSerializationError flakes have been seen (in #6954 and in nightly CI). Honestly I don't really think that these places ought to be having TransactionSerializationErrors, but also it really is pretty required to do retries when using SERIALIZABLE, so we should start moving towards being more consistent about it.
msullivan
added a commit
that referenced
this pull request
Mar 7, 2024
In general we should be using retrying transactions. Our isolated tests do retries at the outside, but non-isolated ones don't necessarily. Implement _run_and_rollback_retrying and use it some places that TransactionSerializationError flakes have been seen (in #6954 and in nightly CI). Honestly I don't really think that these places ought to be having TransactionSerializationErrors, but also it really is pretty required to do retries when using SERIALIZABLE, so we should start moving towards being more consistent about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we should be using retrying transactions. Our isolated
tests do retries at the outside, but non-isolated ones don't
necessarily.
Implement _run_and_rollback_retrying and use it some places that
TransactionSerializationError flakes have been seen (in #6954 and
in nightly CI).
Honestly I don't really think that these places ought to be having
TransactionSerializationErrors, but also it really is pretty required
to do retries when using SERIALIZABLE, so we should start moving
towards being more consistent about it.