Remove dodgy skip_start hack for notebook protocol #6849
Merged
+6
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a hack in execute.execute so that notebook can keep everything in an implicit transaction as far as the dbview is concerned. Instead, just put it all in an explicit dbview transaction.
msullivan
force-pushed
the
no-skip_start
branch
from
f4104de to
407d736
Compare
elprans
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a hack in execute.execute so that notebook can keep
everything in an implicit transaction as far as the dbview is
concerned. Instead, just put it all in an explicit dbview transaction.