Support session and backend extension configs #6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires: * Some special handling for reflection, since extension settings don't show up in the views we look at normally * Updating _apply_session_config to work for extension configs * Making StateSerializerFactory able to include extension configs. To test this, I fixed pg_trgm's configs. pg_trgm attempted to have some backend configs, but the config object didn't extend ExtensionConfig and also the backend_setting wasn't json. I added some checks to the extension path to prevent this sort of mistake. Database configs work too, and I tested it manually, but currently the only reliable way to make database configs with backend settings take effect is to restart the server, so no tests for that yet. The other big motivation for this is pgvector probes, which I'll leave for @vpetrovykh to follow up on.
elprans
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires:
don't show up in the views we look at normally
To test this, I fixed pg_trgm's configs. pg_trgm attempted to have
some backend configs, but the config object didn't extend
ExtensionConfig and also the backend_setting wasn't json. I added
some checks to the extension path to prevent this sort of mistake.
Database configs work too, and I tested it manually, but currently the
only reliable way to make database configs with backend settings take
effect is to restart the server, so no tests for that yet.
The other big motivation for this is pgvector probes, which I'll leave
for @vpetrovykh to follow up on.