Support closing all connections to a database on database drop #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, while adding a test, I realized this was not enough. |
msullivan
reviewed
Feb 5, 2024
Comment on lines
+258
to
+280
| # The frontend connection should be closed by the server now | ||
| self.assertTrue(conn.is_closed()) |
There was a problem hiding this comment.
Are you confident that this will be reflected in the client state already?
There was a problem hiding this comment.
Yeah, the test passed at b851e5c - could be flaky but I haven't met
msullivan
force-pushed
the
t6776-stop-fe-conn
branch
from
2a07fdb to
1686041
Compare
msullivan
force-pushed
the
t6776-stop-fe-conn
branch
from
1686041 to
1204ead
Compare
elprans
reviewed
Feb 13, 2024
edb/edgeql/parser/grammar/ddl.py
Outdated
| _, _, name = kids | ||
| self.val = qlast.DropDatabase(name=name.val) | ||
|
|
||
| def reduce_DROP_BRANCH_RESET_CONNECTIONS_DatabaseName(self, *kids): |
There was a problem hiding this comment.
Not sure I like the formulation. It doesn't read very well and would scale poorly if we add more options. I actually like PostgreSQL's drop database foo [with option, ...] somewhat more. I also like force as a shorter spelling (a-la Postgres also)
msullivan
changed the title
elprans
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop databasewill now interrupt and close idle frontend connections before the actual backend database is dropped. Note, idle-in-transaction frontend connections will also be closed.@msullivan you can configure
close_frontend_conns=Trueconditionally inexecute.pyx.Fixes #6776