Add force_database_error documentation #6667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raddevon
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Nice catch! Would it also make sense to provide a link to a list of errors? Maybe https://github.com/edgedb/edgedb/blob/master/edb/errors/__init__.py
Yeah! Good call, I linked to the page containing them. (There's one in .rst format too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing documentation for the UI today and noticed that force_database_error takes a str instead of a bool, and that the strs it accepts can be pretty verbose. Pretty nice feature to have compared to a simple bool so added two examples of valid input to get users started.