Skip to content

Commit

Permalink
Allow :: in module names in experimental interpreter.
Browse files Browse the repository at this point in the history
  • Loading branch information
dnwpark committed Oct 7, 2024
1 parent 685df34 commit e57ef8b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions edb/tools/experimental_interpreter/schema/ddl_processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ def process_ddl(schema: e.DBSchema, ddl: qlast.DDLOperation) -> None:
case qlast.CreateModule(
name=qlast.ObjectRef(name=module_name), commands=[]
):
assert "::" not in module_name, "TODO"
schema.modules[(module_name,)] = e.DBModule({})
case (
qlast.CreatePseudoType()
Expand All @@ -39,7 +38,6 @@ def process_ddl(schema: e.DBSchema, ddl: qlast.DDLOperation) -> None:
assert (
module_name is not None
), "Scalar types cannot be created in top level"
assert "::" not in module_name, "TODO"
schema.modules[(module_name,)].defs[type_name] = (
e.ModuleEntityTypeDef(
e.ScalarTp(e.QualifiedName([module_name, type_name])),
Expand Down Expand Up @@ -161,7 +159,6 @@ def process_ddl(schema: e.DBSchema, ddl: qlast.DDLOperation) -> None:
assert (
module_name is not None
), "Object types cannot be created in top level"
assert "::" not in module_name, "TODO"
obj_tp, constraints, indexes = elab_schema.elab_create_object_tp(
commands
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def process_builtin_fun_def(
assert (
module_name is not None
), "Functions cannot be created in top level"
assert "::" not in module_name, "TODO"
func_type = elaborate_fun_def_arg_type(params, ret_tp, ret_typemod)
func_type = name_res.fun_arg_ret_type_name_resolve(
eops.emtpy_tcctx_from_dbschema(schema), func_type
Expand Down

0 comments on commit e57ef8b

Please sign in to comment.