Add pg_show_all_settings to allowed pg functions (#8298)

This is used by pgAdmin4 as of 8.12 and replaces their usage of the table `pg_catalog.pg_settings` with `pg_catalog.pg_show_all_settings()`. Closes #8297 See pgadmin-org/pgadmin4#7870
geldata · Feb 4, 2025 · da9b73f · da9b73f
1 parent 6f6a828
commit da9b73f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/edb/pgsql/resolver/static.py b/edb/pgsql/resolver/static.py
@@ -216,6 +216,7 @@ def eval_TypeCast(
         'pg_last_wal_replay_lsn',
         'pg_current_wal_flush_lsn',
         'pg_relation_is_publishable',
+        'pg_show_all_settings',
     }
 )
 

diff --git a/tests/test_sql_query.py b/tests/test_sql_query.py
@@ -1307,7 +1307,8 @@ async def test_sql_query_pgadmin_hack(self):
         await self.scon.execute("SET DateStyle=ISO;")
         await self.scon.execute("SET client_min_messages=notice;")
         await self.scon.execute(
-            "SELECT set_config('bytea_output','hex',false) FROM pg_settings"
+            "SELECT set_config('bytea_output','hex',false)"
+            "  FROM pg_catalog.pg_show_all_settings()"
             " WHERE name = 'bytea_output'; "
         )
         await self.scon.execute("SET client_encoding='WIN874';")