enable F841 (unused vars)

edb/common/markup/renderers/terminal.py

@@ -216,7 +216,7 @@ def check_folded_fit(pos, data, width):
             elif el == HEADER:
                 # ``item[1]`` -- text to output, ``item[2]`` -- its style,
                 #
-                _, text, style, level = el
+                _, text, style, _level = el
                 if item[2] is None:
                     result.append(item[1])
                 else:

edb/edgeql/compiler/inference/cardinality.py

@@ -804,12 +804,12 @@ def __infer_oper_call(
     elif str(ir.func_shortname) == 'std::EXCEPT':
         # EXCEPT cardinality cannot be greater than the first argument, but
         # the lower bound can be ZERO.
-        lower, upper = _card_to_bounds(cards[0])
+        _lower, upper = _card_to_bounds(cards[0])
         return _bounds_to_card(CB_ZERO, upper)
     elif str(ir.func_shortname) == 'std::INTERSECT':
         # INTERSECT takes the minimum of cardinalities and makes the lower
         # bound ZERO.
-        lower, upper = _card_to_bounds(min_cardinality(cards))
+        _lower, upper = _card_to_bounds(min_cardinality(cards))
         return _bounds_to_card(CB_ZERO, upper)
     elif str(ir.func_shortname) == 'std::??':
         # Coalescing takes the maximum of both lower and upper bounds.

edb/edgeql/parser/grammar/ddl.py

@@ -742,7 +742,7 @@ def reduce_CREATE_DATABASE_from_template(self, *kids):
             CREATE DATABASE DatabaseName FROM AnyNodeName
             OptCreateDatabaseCommandsBlock
         """
-        _, _, name, _, template, commands = kids
+        _, _, _name, _, _template, _commands = kids
         self.val = qlast.CreateDatabase(
             name=kids[2].val,
             commands=kids[5].val,

edb/graphql/translator.py

@@ -532,7 +532,7 @@ def visit_FieldNode(self, node):
         if self._is_duplicate_field(node):
             return
 
-        is_top, path, prevt, target, steps = \
+        _is_top, _path, prevt, target, steps = \
             self._prepare_field(node)
 
         json_mode = False

edb/pgsql/compiler/relgen.py

@@ -1817,7 +1817,7 @@ def process_set_as_coalesce(
     with ctx.new() as newctx:
         newctx.expr_exposed = False
         left_ir, right_ir = (a.expr for a in expr.args)
-        left_card, right_card = (a.cardinality for a in expr.args)
+        _left_card, right_card = (a.cardinality for a in expr.args)
         is_object = (
             ir_set.path_id.is_objtype_path()
             or ir_set.path_id.is_tuple_path()

edb/pgsql/delta.py

@@ -2679,7 +2679,7 @@ def _undo_everything(
                 pass
 
             if prop.get_default(schema):
-                delta_alter, cmd_alter, alter_context = prop.init_delta_branch(
+                delta_alter, cmd_alter, _alter_context = prop.init_delta_branch(
                     schema, context, cmdtype=sd.AlterObject)
                 cmd_alter.set_attribute_value('default', None)
                 cmd.add(delta_alter)
@@ -2716,7 +2716,7 @@ def _undo_everything(
             elif isinstance(obj, s_props.Property):
                 new_typ = props[obj]
 
-                delta_alter, cmd_alter, alter_context = obj.init_delta_branch(
+                delta_alter, cmd_alter, _alter_context = obj.init_delta_branch(
                     schema, context, cmdtype=sd.AlterObject)
                 cmd_alter.set_attribute_value('target', new_typ)
                 cmd_alter.set_attribute_value('default', None)

edb/schema/pointers.py

@@ -1799,7 +1799,7 @@ def validate_object(
             # because it's impossible to actually guarantee that any
             # SELECT involving a path is non-empty
             ptr_cardinality = scls.get_cardinality(schema)
-            default_required, default_cardinality = \
+            _default_required, default_cardinality = \
                 default_expr.irast.cardinality.to_schema_value()
 
             if (ptr_cardinality is qltypes.SchemaCardinality.One

edb/schema/reflection/structure.py

@@ -524,7 +524,7 @@ def generate_structure(
                     read_ptr = f'{read_ptr}[IS {rschema_name}]'
 
                 if field.reflection_proxy:
-                    proxy_type, proxy_link = field.reflection_proxy
+                    _proxy_type, proxy_link = field.reflection_proxy
                     read_ptr = (
                         f'{read_ptr}: {{name, value := .{proxy_link}.id}}'
                     )

edb/server/compiler_pool/server.py

@@ -381,12 +381,12 @@ async def _call_for_client(
             if status == 0:
                 worker.set_client_schema(client_id, client_schema)
                 if method_name == "compile":
-                    units, new_pickled_state = data[0]
+                    _units, new_pickled_state = data[0]
                     if new_pickled_state:
                         sid = worker._last_pickled_state = next_tx_state_id()
                         resp = pickle.dumps((0, (*data[0], sid)), -1)
             elif status == 1:
-                exc, tb = data
+                exc, _tb = data
                 if not isinstance(exc, state_mod.FailedStateSync):
                     worker.set_client_schema(client_id, client_schema)
             else:

edb/server/pgcluster.py

@@ -339,7 +339,7 @@ async def _copy_database(
         pg_restore = self._find_pg_binary('pg_restore')
 
         src_conn_args, src_env = self._dump_restore_conn_args(src_dbname)
-        tgt_conn_args, tgt_env = self._dump_restore_conn_args(tgt_dbname)
+        tgt_conn_args, _tgt_env = self._dump_restore_conn_args(tgt_dbname)
 
         dump_args = [
             pg_dump, '--verbose', '--format=c', *src_conn_args, *src_args

edb/testbase/http.py

@@ -68,7 +68,7 @@ async def _wait_for_db_config(
                     (
                         rdata,
                         _headers,
-                        status,
+                        _status,
                     ) = cls.http_con_request(
                         http_con,
                         prefix="",

pyproject.toml

@@ -221,9 +221,6 @@ lint.ignore = [
     "E731",  # Do not assign a lambda expression, use a def
     "E741",  # Ambiguous variable name: l or i or I
     "E252",  # Missing whitespace around parameter equals
-
-             # TODO: enable this
-    "F841",  # unused variable
 
              # TODO: enable this
     "B905",  # zip() without an explicit strict= parameter
@@ -238,4 +235,3 @@ exclude = ["postgres", ".github"]
 lint.flake8-bugbear.extend-immutable-calls = [
     "immutables.Map"
 ]
-

tests/test_backend_connect.py

@@ -183,7 +183,7 @@ def get_connection_spec(cls, kwargs=None):
         conn_spec = cls.cluster.get_connection_spec()
         conn_spec['host'] = 'localhost'
         if kwargs.get('dsn'):
-            addrs, params = pgconnparams.parse_dsn(kwargs['dsn'])
+            _addrs, params = pgconnparams.parse_dsn(kwargs['dsn'])
             for k in (
                 'user',
                 'password',

tests/test_edgeql_extensions.py

@@ -668,7 +668,7 @@ async def _check(_cfg_obj='Config', **kwargs):
             async for tr in self.try_until_succeeds(ignore=AssertionError):
                 async with tr:
                     with self.http_con() as http_con:
-                        rdata, _headers, status = self.http_con_request(
+                        rdata, _headers, _status = self.http_con_request(
                             http_con,
                             prefix="",
                             path="server-info",

tests/test_edgeql_update.py

@@ -255,7 +255,7 @@ async def test_edgeql_update_simple_05(self):
         )
 
     async def test_edgeql_update_returning_01(self):
-        orig1, orig2, orig3 = self.original
+        _orig1, orig2, _orig3 = self.original
 
         await self.assert_query_result(
             r"""
@@ -326,7 +326,7 @@ async def test_edgeql_update_returning_02(self):
         )
 
     async def test_edgeql_update_returning_03(self):
-        orig1, orig2, orig3 = self.original
+        _orig1, _orig2, _orig3 = self.original
 
         await self.assert_query_result(
             r"""

tests/test_http_auth.py

@@ -117,8 +117,8 @@ def _scram_auth_expect_failure(self, user, password):
             content,
             headers,
             status,
-            sid,
-            expected_server_sig,
+            _sid,
+            _expected_server_sig,
         ) = self._scram_auth(user, password)
         self.assertEqual(status, 401)
         self.assertEqual(content, b"Authentication failed")

tests/test_http_ext_auth.py

@@ -2555,7 +2555,7 @@ async def test_http_auth_ext_local_password_register_json_02(self):
             }
             json_data_encoded = json.dumps(json_data).encode()
 
-            body, headers, status = self.http_con_request(
+            body, _headers, status = self.http_con_request(
                 http_con,
                 None,
                 path="register",
@@ -2721,7 +2721,7 @@ async def test_http_auth_ext_local_password_authenticate_01(self):
             }
             auth_data_encoded = urllib.parse.urlencode(auth_data).encode()
 
-            body, headers, status = self.http_con_request(
+            body, _headers, status = self.http_con_request(
                 http_con,
                 None,
                 path="authenticate",
@@ -3765,7 +3765,7 @@ async def test_http_auth_ext_webauthn_authenticate_options(self):
                 public_key=public_key,
             )
 
-            body, headers, status = self.http_con_request(
+            body, _headers, status = self.http_con_request(
                 http_con,
                 path=f"webauthn/authenticate/options?email={email}",
             )

tests/test_server_compiler.py

@@ -134,7 +134,7 @@ async def check_pid(self, pid, server):
 
     async def test_server_compiler_pool_restart(self):
         pids = []
-        async with self.compiler_pool(2) as (server, proto, proc, sn):
+        async with self.compiler_pool(2) as (server, proto, _proc, _sn):
             # Make sure both compiler workers are up and ready
             pid1 = await asyncio.wait_for(proto.connected.get(), LONG_WAIT)
             pid2 = await asyncio.wait_for(proto.connected.get(), SHORT_WAIT)
@@ -177,7 +177,7 @@ async def test_server_compiler_pool_restart(self):
                 os.kill(pid, 0)
 
     async def test_server_compiler_pool_template_proc_exit(self):
-        async with self.compiler_pool(2) as (server, proto, proc, sn):
+        async with self.compiler_pool(2) as (server, proto, proc, _sn):
             # Make sure both compiler workers are up and ready
             pid1 = await asyncio.wait_for(proto.connected.get(), LONG_WAIT)
             pid2 = await asyncio.wait_for(proto.connected.get(), SHORT_WAIT)
@@ -214,7 +214,7 @@ async def test_server_compiler_pool_template_proc_exit(self):
                     os.kill(pid, 0)
 
     async def test_server_compiler_pool_server_exit(self):
-        async with self.compiler_pool(2) as (server, proto, proc, sn):
+        async with self.compiler_pool(2) as (server, proto, proc, _sn):
             # Make sure both compiler workers are up and ready
             pid1 = await asyncio.wait_for(proto.connected.get(), LONG_WAIT)
             pid2 = await asyncio.wait_for(proto.connected.get(), SHORT_WAIT)

tests/test_server_ops.py

@@ -1316,7 +1316,7 @@ async def _test_server_ops_global_compile_cache(
         ) as http_con:
             async for tr in self.try_until_succeeds(ignore=AssertionError):
                 async with tr:
-                    response, _, status = self.http_con_json_request(
+                    _response, _, status = self.http_con_json_request(
                         http_con,
                         path=f"/db/{conn.dbname}/ext/auth/register",
                         body={