Skip to content

Commit

Permalink
Fix issue in SQL-over-native where normalization is required (#8122)
Browse files Browse the repository at this point in the history
We index into extra_counts unconditionally, which is wrong.
This will fix #8104.

I'm splitting it out because if we merge #8104, we will want to revert
it eventually, but we want this fix to survive.
  • Loading branch information
msullivan authored Dec 13, 2024
1 parent 102e4de commit d64473b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions edb/server/protocol/args_ser.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,9 @@ cdef WriteBuffer recode_bind_args(
for _ in range(recv_args):
out_buf.write_int16(0x0001)
# and extracted SQL constants are in text
for _ in range(compiled.extra_counts[0]):
out_buf.write_int16(0x0000)
if compiled.extra_counts:
for _ in range(compiled.extra_counts[0]):
out_buf.write_int16(0x0000)
# and injected globals are binary again
for _ in range(num_globals):
out_buf.write_int16(0x0001)
Expand Down

0 comments on commit d64473b

Please sign in to comment.