Always print all labels in /metrics

geldata · May 23, 2024 · 754386f · 754386f
1 parent 165de00
commit 754386f
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/edb/common/prometheus.py b/edb/common/prometheus.py
@@ -409,7 +409,6 @@ def _generate(self, buffer: list[str], **label_filters: str) -> None:
             fmt_label = ','.join(
                 f'{label}="{_format_label_val(label_val)}"'
                 for label, label_val in zip(self._labels, labels)
-                if label not in label_filters
             )
             buffer.append(
                 f'{self._name}{self._suffix}{{{fmt_label}}} {float(value)}'
@@ -425,7 +424,6 @@ def _generate(self, buffer: list[str], **label_filters: str) -> None:
                 fmt_label = ','.join(
                     f'{label}="{_format_label_val(label_val)}"'
                     for label, label_val in zip(self._labels, labels)
-                    if label not in label_filters
                 )
                 buffer.append(
                     f'{self._name}_created{{{fmt_label}}} {float(value)}'
@@ -618,7 +616,6 @@ def _generate(self, buffer: list[str], **label_filters: str) -> None:
             fmt_label = ','.join(
                 f'{label}="{_format_label_val(label_val)}"'
                 for label, label_val in zip(self._labels, labels)
-                if label not in label_filters
             )
             accum = 0.0
             for buck, val in zip(self._buckets, values[1]):  # type: ignore
@@ -648,7 +645,6 @@ def _generate(self, buffer: list[str], **label_filters: str) -> None:
                 fmt_label = ','.join(
                     f'{label}="{_format_label_val(label_val)}"'
                     for label, label_val in zip(self._labels, labels)
-                    if label not in label_filters
                 )
                 buffer.append(
                     f'{self._name}_created{{{fmt_label}}} {float(value)}'