server: add missing args env vars

geldata · Jun 19, 2024 · 336914f · 336914f
1 parent e1f5c1a
commit 336914f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/docs/reference/environment.rst b/docs/reference/environment.rst
@@ -274,6 +274,13 @@ and ``*_ENV`` variants are also supported.
 .. _URI format:
    https://www.postgresql.org/docs/13/libpq-connect.html#id-1.7.3.8.3.6
 
+EDGEDB_SERVER_MAX_BACKEND_CONNECTIONS
+.....................................
+
+The maximum NUM of connections this EdgeDB instance could make to the backend
+PostgreSQL cluster. If not set, EdgeDB will detect and calculate the NUM:
+RAM/100MiB for local Postgres, or pg_settings.max_connections for remote
+Postgres minus the NUM of ``--reserved-pg-connections``.
 
 EDGEDB_SERVER_BINARY_ENDPOINT_SECURITY
 ......................................

diff --git a/edb/server/args.py b/edb/server/args.py
@@ -631,6 +631,7 @@ def resolve_envvar_value(self, ctx: click.Context):
         '--tenant-id',
         type=str,
         callback=_validate_tenant_id,
+        envvar="EDGEDB_SERVER_TENANT_ID",
         help='Specifies the tenant ID of this server when hosting'
              ' multiple EdgeDB instances on one Postgres cluster.'
              ' Must be an alphanumeric ASCII string, maximum'
@@ -730,6 +731,7 @@ def resolve_envvar_value(self, ctx: click.Context):
              f'by default)'),
     click.option(
         '--max-backend-connections', type=int, metavar='NUM',
+        envvar="EDGEDB_SERVER_MAX_BACKEND_CONNECTIONS",
         help=f'The maximum NUM of connections this EdgeDB instance could make '
              f'to the backend PostgreSQL cluster. If not set, EdgeDB will '
              f'detect and calculate the NUM: RAM/100MiB='
@@ -739,11 +741,13 @@ def resolve_envvar_value(self, ctx: click.Context):
         callback=_validate_max_backend_connections),
     click.option(
         '--compiler-pool-size', type=int,
+        envvar="EDGEDB_SERVER_COMPILER_POOL_SIZE",
         callback=_validate_compiler_pool_size),
     click.option(
         '--compiler-pool-mode',
         type=CompilerPoolModeChoice(),
         default=CompilerPoolMode.Default.value,
+        envvar="EDGEDB_SERVER_COMPILER_POOL_MODE",
         help='Choose a mode for the compiler pool to scale. "fixed" means the '
              'pool will not scale and sticks to --compiler-pool-size, while '
              '"on_demand" means the pool will maintain at least 1 worker and '
@@ -755,6 +759,7 @@ def resolve_envvar_value(self, ctx: click.Context):
         '--compiler-pool-addr',
         hidden=True,
         callback=_validate_host_port,
+        envvar="EDGEDB_SERVER_COMPILER_POOL_ADDR",
         help=f'Specify the host[:port] of the compiler pool to connect to, '
              f'only used if --compiler-pool-mode=remote. Default host is '
              f'localhost, port is {defines.EDGEDB_REMOTE_COMPILER_PORT}',
@@ -764,6 +769,7 @@ def resolve_envvar_value(self, ctx: click.Context):
         hidden=True,
         type=int,
         default=100,
+        envvar="EDGEDB_SERVER_COMPILER_POOL_TENANT_CACHE_SIZE",
         help="Maximum number of tenants for which each compiler worker can "
              "cache their schemas, "
              "only used when --compiler-pool-mode=fixed_multi_tenant"