Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and apply initial migration in the @edgedb/create CLI; minor CLI changes #854

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Create and apply initial migration in the @edgedb/create CLI; minor CLI changes #854

merged 4 commits into from
Feb 7, 2024

Conversation

beerose
Copy link
Member

@beerose beerose commented Feb 7, 2024 •
edited
Loading

Note: updated README.md files will follow.

Also added this outro message:
CleanShot 2024-02-07 at 13 28 25@2x

beerose
beerose commented Feb 7, 2024
View reviewed changes
@beerose beerose requested a review from scotttrinh February 7, 2024 12:30
scotttrinh
scotttrinh approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers here! You're welcome to do the chalk -> picocolors and/or moving the intro and outro to cli.ts at your preference. Awesome job. Adding the intro and outro are nice touches!

@beerose beerose merged commit d7434c7 into master Feb 7, 2024
8 checks passed
@beerose beerose deleted the create-cli-improvements branch February 7, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotttrinh scotttrinh scotttrinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beerose @scotttrinh